New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript: Preserve decorated definite class properties #11129
Merged
nicolo-ribaudo
merged 2 commits into
babel:master
from
jamescdavis:preserve_decorated_definite_class_properties
Feb 27, 2020
Merged
Typescript: Preserve decorated definite class properties #11129
nicolo-ribaudo
merged 2 commits into
babel:master
from
jamescdavis:preserve_decorated_definite_class_properties
Feb 27, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
area: typescript
PR: Bug Fix 🐛
A type of pull request used for our changelog categories
labels
Feb 12, 2020
nicolo-ribaudo
approved these changes
Feb 26, 2020
Thanks! |
JLHwung
reviewed
Feb 27, 2020
jamescdavis
force-pushed
the
preserve_decorated_definite_class_properties
branch
from
February 27, 2020 20:08
af70f4b
to
5e7a0d7
Compare
JLHwung
approved these changes
Feb 27, 2020
@jamescdavis Can you rebase on upstream master? The e2e error will be fixed after rebasing. |
This was referenced Mar 7, 2020
This was referenced Mar 14, 2020
This was referenced Mar 22, 2020
This was referenced Apr 11, 2020
This was referenced Apr 20, 2020
This was referenced Apr 27, 2020
This was referenced May 5, 2020
github-actions
bot
added
the
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
label
May 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area: typescript
outdated
A closed issue/PR that is archived due to age. Recommended to make a new issue
PR: Bug Fix 🐛
A type of pull request used for our changelog categories
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #8238, but for class properties marked as definite (using the non-null assertion
!
)Current behavior:
The
babel-plugin-transform-typescript
removes class properties marked as definite regardless if decorators are assigned to it or not.Expected behavior:
The babel-plugin-transform-typescript should only remove a definite class property if it has no decorators.